Caideyipi commented on PR #19087:
URL: https://github.com/apache/iotdb/pull/19087#issuecomment-6593412040

   Initial independent review completed. I reviewed the full two-file diff and 
the related DELETE parser, schema-name normalization, device-filter resolution, 
and test lifecycle/assertions. No actionable issues were found, and no code 
changes, new commits, or pushes were needed.
   
   Reviewed SHA, final local HEAD, and confirmed source-branch/PR head: 
`dfe0bfe736f877a6d9179b431d1fb3a659849b33` (base: 
`24fd30e1ac6b43a32aaeca2066034b1ae81fbc44`). The PR has been marked ready for 
review.
   
   Validation:
   
   - `git diff --check` passed. No build or executable tests were rerun during 
this review. The existing implementation record for this SHA reports 4 selected 
tests passed under each of `TableSimpleIT` and `TableClusterIT`.
   - GitHub checks currently report 40 successes and 2 failures; CI is not 
fully green.
   - [Simple 
(17)](https://github.com/apache/iotdb/actions/runs/41435813220/job/125245183215)
 failed in 
`IoTDBLoadTsFileActiveScanIT.testIncompletePublicationSurvivesScannerRestartAndPreservesMods`,
 timing out while waiting for `root.p1scan.incomplete.after`. That tree-model 
LOAD test and its execution path are outside this diff; the failure was not 
reproduced or repaired in this review.
   - 
[SonarCloud](https://sonarcloud.io/dashboard?id=apache_iotdb&pullRequest=19087) 
reports `java:S3078` in unchanged `PipeTaskInfo.java`. That separate warning 
was left unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to