Caideyipi commented on PR #19095: URL: https://github.com/apache/iotdb/pull/19095#issuecomment-6593791527
Initial independent self-review completed for `4c9ea8a830164081ee878ca4849fd5268f6c36ce`, against base `24fd30e1ac6b43a32aaeca2066034b1ae81fbc44`. No actionable issues were found in the complete three-file diff and relevant context. The review covered observation timing, immediate assertion failures and failure callbacks, the slow-query proxy, test selection, and restart/session/result-set lifecycles. The original regression concerns server-side cache invalidation; reopening the client retains that scenario. No code fixes were needed. Validation: `git diff --check` passed. No compilation or IT execution was repeated in this read-only review. The earlier targeted verification stopped before running ITs because Maven's remote-resources plugin could not acquire dependency locks; a retry is building, and the targeted TableSimpleIT/TableClusterIT and SimpleIT/ClusterIT results remain unverified. The local selection script was blocked by Windows resolving Bash to unavailable WSL. The Linux baseline selection check passed; the new method inherits the existing class categories. GitHub CI is still pending. A pre-existing issue remains outside this PR: in `Session.close()`, an exception while closing one cached connection skips the remaining connection closes, while `finally` marks the session closed. This was left unchanged and should receive a separate cleanup fix and regression test. Final local commit and confirmed source-branch/PR head: `4c9ea8a830164081ee878ca4849fd5268f6c36ce`. No branch update was required. The code review passed and the PR has been marked ready for review; this does not claim that pending validation passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
