d-wang-commit opened a new pull request, #19101:
URL: https://github.com/apache/iotdb/pull/19101
## Description
### Fix procedure snapshot file selection
Ratis snapshot installation creates `.md5` checksum files alongside snapshot
data. `ProcedureInfo` previously attempted to deserialize every entry in the
`procedures` directory except `procedure_info.bin`, including
`procedure_info.bin.md5` and `<procId>.bin.md5`. The checksum text was
interpreted as a procedure type, producing errors and causing the checksum
files to be deleted by the failed-load cleanup.
Load only regular files ending in `.bin`, while continuing to handle
`procedure_info.bin` separately. This preserves checksum files and avoids
attempting to deserialize them as procedures.
### Tests
- UT: added `testSnapshotWithMd5Files` and `testEmptySnapshotWithMd5File` in
`ProcedureInfoTest`. They create real Ratis MD5 files, verify restored
procedure state and the last procedure ID, and check that checksum files remain
present and valid.
- Validation: targeted compilation of `ProcedureInfo` and
`ProcedureInfoTest` against the existing module artifact and dependencies,
followed by JUnit execution, passed all 4 tests. Both new tests fail with the
original loader. Spotless passed.
- IT: no integration tests added or run; the regression tests exercise the
snapshot loader directly.
### Side effects and risks
Non-`.bin` files and directories are now ignored during procedure loading.
Existing procedure snapshots use `<procId>.bin`, and the snapshot format and
main metadata loading are unchanged. The change adds a file-type check per
directory entry without changing procedure serialization or recovery ordering.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are
corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes,
inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods,
parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of
emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative
name) for every design
(or naming) decision point and compare the alternatives with the designs
that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen
designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in
this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development
mailing list),
link to that discussion from this PR description and explain what have
changed in your final design
compared to your original proposal or the consensus version in the end of
the discussion.
If something hasn't changed since the original discussion, you can omit a
detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for
the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small
changes. -->
<hr>
This PR has:
- [x] been self-reviewed.
- [x] added unit tests or modified existing tests to cover new code paths.
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items
apply to every PR. Remove the items which are not done or not relevant to
the PR. None of the items
from the checklist above are strictly necessary, but it would be very
helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes)
in this PR
- `ProcedureInfo`: restrict procedure snapshot deserialization to regular
`.bin` files.
- `ProcedureInfoTest`: cover snapshots containing MD5 sidecars with and
without procedures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]