Caideyipi commented on PR #19103: URL: https://github.com/apache/iotdb/pull/19103#issuecomment-6595485922
<!-- codex-pr-workflow:19103:initial-self-review:35dcbb6d371587ef2bb5347c7a295e4363e12999 --> Initial independent self-review, round 1 completed. Reviewed the complete diff against current `apache/iotdb:master` (`e6b44b57e49e1e7f0ecf5d6c62fa7e1f69a9a869`), including the snapshot helper, replica convergence and post-restart assertions, file finalization/resource publication, and test cleanup. - Findings: no actionable issues. The resource-sidecar filter matches the sealed-file lifecycle. Regression coverage retains readable sealed data, skips empty/incomplete unsealed files, and requires corrupt sealed files to fail. - Fixes: none required; no source edits, new commits, or push were needed. - Verification: inspected the preserved local Windows/JDK 17 targeted `ClusterIT` reports: 2 tests passed, 0 failures/errors/skips. All newly added tests ran locally. The record confirms clean-source reactor dependencies, Spotless apply with `with-integration-tests`, and IT selection/shard checks. This round's diff whitespace check passed; builds/tests were not rerun because the reviewed source is unchanged. - Reviewed SHA: `35dcbb6d371587ef2bb5347c7a295e4363e12999`. - Final local SHA: `35dcbb6d371587ef2bb5347c7a295e4363e12999`. - Confirmed source-branch SHA and PR HEAD: `35dcbb6d371587ef2bb5347c7a295e4363e12999` (`Caideyipi/iotdb:fix/load-restart-tsfile-snapshots-20261103`). The worktree is clean. - Full IT suite was not run; CI remains incomplete. No update step is blocked or outstanding. The PR remains Draft as explicitly requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
