PDGGK commented on PR #19105:
URL: https://github.com/apache/iotdb/pull/19105#issuecomment-6604205168

   Thanks for the update. I reran the earlier checks against 7330aef, with the 
same setup as before:
   
   - The query from my comment now returns three rows, ending with the null row 
for the `Long.MAX_VALUE` window.
   - When one group has a real row at `Long.MAX_VALUE` and another group 
follows, there is no longer a duplicate gap row at the group switch.
   - The examples in #18988 now include the last window, and the 38 queries in 
`IoTDBGapFillTableIT` return the same rows as before.
   
   Looks good to me. One thought on tests: the existing gap-fill operator tests 
and the `IoTDBGapFillTableIT` queries give the same results with and without 
this change, so they wouldn't catch either case if it came back. I have a small 
unit test that drives the operator directly, and I'm happy to share it if that 
helps.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to