chrisdutz commented on PR #19086: URL: https://github.com/apache/iotdb/pull/19086#issuecomment-6654504743
Thanks for the thorough review, you're right on all points. I've reworked the PR: - The commit message and the description now name `PROACTIVE` (since #18692) as the cause and mention CI's 1 GB heap; the "same settings as before" claim is gone. - The heap scaling is replaced with your suggestion, `setDataRegionPerDataNode(2)` before `initClusterEnvironment()`, so the inline comments on the heap formula no longer apply. - The branch is rebased onto the current master, which includes #19109, so the SonarCloud gate should pass now. I've left the `setMaxTsBlockLineNumber(2).setMaxNumberOfPointsInPage(5)` ordering as it is. Applying those settings changes the effective configuration of the test, so I'd rather do that in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
