CritasWang opened a new pull request, #19138:
URL: https://github.com/apache/iotdb/pull/19138

   ## What changes
   
   The header validation message of `import-schema` tells users that the 
correct CSV format is
   `"Timeseries, **Alibaba**, DataType, Encoding, Compression"`, but the column 
name that
   `export-schema` actually writes is `Alias`. The message therefore points 
users at a column
   name that does not exist.
   
   Reproduced on a real standalone cluster by importing a CSV whose header 
contains `Tags`
   instead of `Alias`:
   
   ```
   The header of the CSV file to be imported is illegal. The correct format is 
"Timeseries, Alibaba, DataType, Encoding, Compression"!
   ```
   
   ## Changes
   
   | File | Change |
   | --- | --- |
   | 
`iotdb-client/cli/src/main/i18n/en/org/apache/iotdb/cli/i18n/CliMessages.java` 
| `Alibaba` → `Alias` |
   | 
`iotdb-client/cli/src/main/i18n/zh/org/apache/iotdb/cli/i18n/CliMessages.java` 
| same fix in the Chinese message |
   | 
`iotdb-client/cli/src/main/java/org/apache/iotdb/tool/schema/ImportSchemaTree.java`
 | update the reference |
   
   The constant is renamed together with the message
   (`..._TIMESERIES_ALIBABA_..._C429E7C6` → 
`..._TIMESERIES_ALIAS_..._FB573E37`) so that its name
   still derives from the English value, as required by the i18n constant 
naming convention. The
   new hash is computed the same way as the old one — the old `C429E7C6` was 
reproduced from the
   old English value to confirm the method (first 8 hex chars of the md5, 
uppercased).
   
   ## History of the typo
   
   The typo was introduced together with the tool itself and survived two 
refactors:
   
   - `8a6e31ffe5` (2024-06-01, #12623): tool introduced, typo born as a raw 
string literal
   - `9132389e4f` (2025-04-02, #15192): files moved, typo moved verbatim
   - `cceb9e70d5` (2026-11-02, #19066): i18n extraction, and the Chinese 
message copied the typo
   
   ## How verified
   
   - `mvn test-compile -DskipTests` → BUILD SUCCESS
   - `mvn test-compile -DskipTests -P with-zh-locale` → BUILD SUCCESS
   - `mvn spotless:apply -pl iotdb-client/cli`
   - `grep -r "Alibaba"` over the source tree returns nothing
   - manually verified the corrected message on a real standalone cluster
   
   No behavior change: only the message text and its constant name differ.
   
   ---
   
   Found while investigating whether `export-schema` supports exporting tags 
and aliases; that
   is a separate topic, not addressed here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to