Caideyipi commented on PR #19131: URL: https://github.com/apache/iotdb/pull/19131#issuecomment-6656859767
Initial independent self-review round Reviewed SHA: `51a15f52e87640018e5b776b61c540eb158eb684`. Target: `master`; inspected target SHA: `fc6f68c213230d0bb166420f901f3bc8b00663ba`; merge base: `e92ecf1d5d62de0c67a52e80ff6cb7e307ab6583`. No actionable findings. Reviewed the complete two-file target diff and both commits, together with the authentication result producer, column definitions, JDBC lookup, and assertion helpers: - `integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/manual/IoTDBPipeInclusionIT.java:309` and `:357`: the constants preserve `UserId,User,` and `Role,Scope,Privileges,GrantOption,`, including column order and trailing commas. - `integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/manual/IoTDBPipePermissionIT.java:195` and `:260`: the JDBC lookup remains `User`, and the result header retains both user columns. Verification: `git diff --check` passed. Source-level comparison confirmed that all changed files are token-identical to the base after resolving the string constants and concatenations and removing the added imports. The current target has no intervening changes in either modified file or the column-definition file. No code changes or new tests were required. Compilation and integration tests were not run in this round because the changes only reuse existing string constants and preserve the checked code. Final local SHA and confirmed remote source-branch/PR SHA: `51a15f52e87640018e5b776b61c540eb158eb684`. The actual source repository is `apache/iotdb`. The source head was rechecked immediately before restoring Ready. No commit or push was necessary. This complete round passed the review gate. At the CI snapshot, 2 check runs had succeeded and 28 were still running; the combined commit status was pending. No remote CI wait was performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
