HTHou opened a new pull request, #19074:
URL: https://github.com/apache/iotdb/pull/19074

   ## Description
   
   Selecting an SSLContext algorithm does not consistently restrict the 
accepted TLS versions. On SunJSSE 17, Thrift configured with 
`ssl_protocol=TLSv1.2` can still accept TLS 1.3, while REST configured with 
`TLSv1.3` also accepts TLS 1.2.
   
   Apply explicit versions through `SSLServerSocket.setEnabledProtocols` for 
Thrift and Jetty's `setIncludeProtocols` for REST. Keep Thrift socket creation 
and failure cleanup in `RpcSslUtils`, and share the protocol restriction 
decision with REST.
   
   Preserve provider defaults for generic `TLS`, `SSL`, and `TLCP` contexts. 
Preserve `TLCPv1.1` defaults as well: its context already enables only TLCP 
1.1, and Kona 17 can omit it from the supported-protocol list, so a Jetty 
inclusion filter would otherwise disable existing TLCP connections.
   
   ## Validation
   
   - `mvn spotless:apply -pl 
iotdb-client/service-rpc,iotdb-core/node-commons,external-service-impl/rest`
   - `mvn test -pl iotdb-client/service-rpc,external-service-impl/rest -am 
-Dtest=RpcUtilsTest#testSslServerSocketEnabledProtocols,RestServiceTest 
-Dsurefire.failIfNoSpecifiedTests=false` — 4 tests passed on Corretto 17.0.18.
   - Reran the same 4 regression tests on Kona 17.0.19 using JUnitCore with the 
Maven-generated test classpath — 4 passed, including the actual TLCP SSLEngine 
check.
   - `mvn test-compile -DskipTests`
   - `mvn test-compile -DskipTests -P with-zh-locale`
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added regression tests for explicit TLS versions, generic/default 
configurations, and TLCP compatibility.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to