Caideyipi commented on PR #19182: URL: https://github.com/apache/iotdb/pull/19182#issuecomment-6734730613
Independent re-review passed; no fixes were needed. - Reviewed commit and final local commit: `2e5461cc8de313be5bab36080fcde17e5e04c5c8`. - Confirmed remote source branch and PR head: both `2e5461cc8de313be5bab36080fcde17e5e04c5c8`. - Rebased the two PR commits onto `origin/master` at `36c35f63b6506910b365d6e487cd8ca2700bc5d6` without conflicts. Both commits are patch-equivalent to the original series (`ce8a21825256a9181b01df1115cf6a8db0d3538d`, `10bb7db5b595fba65678bfcfd7b35afeff11ef5f`). Reviewed the complete current diff and relevant context, with particular attention to TTL authorization intersections, database TTL compatibility, split-event ordering and progress, snapshot parsing, privilege retries, and the shared source API's consumers. No actionable issues were found. Validation: a clean 29-project dependency reactor build passed with build caching disabled (499 goals executed). All 37 tests in `IoTDBNonDataRegionSourceTest`, `PipeConfigTreePrivilegeParseVisitorTest`, and `PipeConfigTreePatternParseVisitorTest` passed with no failures, errors, or skips. The build's Spotless and Checkstyle checks passed. Repository-wide builds, the Chinese locale, and integration tests were not run in this session. Remote CI for the rebased head is separate and has not been awaited. There are no incomplete branch-update steps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
