Caideyipi commented on PR #19190:
URL: https://github.com/apache/iotdb/pull/19190#issuecomment-6760305412

   Review comment follow-up
   
   Starting head: `7a36a4f54258d8dd1e26ca23faddfb9c59bc0c64`.
   Final local commit, confirmed source-branch head, and confirmed PR head: 
`fa9a85ab732977e989ab4764550b2282e7b48a5c`.
   
   - Extracted reusable positional and sequential `IOUtils.writeFully` helpers 
and adopted them throughout schema-file channel writes.
   - Added an ArchUnit guard for the schema-file production package, with 
fixtures checking every raw write overload and the permitted helper calls.
   - Local validation passed: 40 unit tests, English compilation, Chinese test 
compilation for the 28 relevant reactor modules, Spotless, message-key parity, 
and `git diff --check`. All newly added tests were run locally. IoTDB 
dependencies were rebuilt from clean source with the build cache disabled; 
unchanged outputs from that same run were reused after correcting a test-only 
Mockito compatibility error.
   - Full-repository compilation was not completed: public dependency downloads 
exceeded the verification budget. Remote tests were not run after public 
dependency endpoints timed out during preflight. Integration tests were not run.
   - Regarding the Codecov report: added direct coverage for short writes, 
buffer bounds, empty buffers, no progress, exception propagation, and 
channel-position semantics. Coverage percentages were not recomputed locally; 
the existing report predates this update.
   
   The PR remains ready for review. Discussions are left unresolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to