Caideyipi opened a new pull request, #19202:
URL: https://github.com/apache/iotdb/pull/19202

   ## Description
   
   When `datanode_memory_proportion` uses the legacy five-part form, the Pipe 
memory calculation adds the QueryEngine, SchemaEngine, and Consensus budgets 
instead of subtracting them. For example, with a 10 GiB maximum heap and 
`3:3:1:1:2`, the first four budgets total 8 GiB, but Pipe is incorrectly 
assigned 6 GiB.
   
   Subtract all four allocated budgets before dividing the remaining memory by 
two, giving Pipe 1 GiB in that example. Add regression coverage for five-part 
proportions, zero remaining memory, explicit six-part Pipe proportions, and the 
deprecated configuration key.
   
   ## Validation
   
   - `mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode` 
passed.
   - Built the required TsFile revision and IoTDB prerequisite modules from 
clean source with build caches disabled.
   - Against the unmodified source, the new suite reports 8 tests with 4 
expected failures: both five-part scenarios fail under both configuration keys, 
while all six-part cases pass.
   - With the fix, `DataNodeMemoryProportionTest`, `DataNodeMemoryConfigTest`, 
and `IoTDBDescriptorSystemPropertiesTest` pass: 24 tests, 0 failures, 0 errors, 
0 skipped.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to