chrisdutz commented on PR #19174: URL: https://github.com/apache/iotdb/pull/19174#issuecomment-6766959166
@jt2594838 Thanks for the review. I added two tests to `WALNodeTest`. Both set a WAL entry limit of 1 MB, as with the edge profile's `wal_buffer_size_in_byte`, and fill the WAL through a second, flushed memtable, so that the cleanup has to snapshot or flush the oldest active memtable in the latest time partition: - `testMemTableLargerThanAWalEntryIsFlushedInsteadOfSnapshotted`: a memtable of 2 MB (below the 8 MB snapshot threshold, above the entry limit) is flushed and the region's write lock is never taken for a snapshot. Without the fix this test fails, because the memtable is snapshotted. - `testMemTableWithinAWalEntryIsSnapshotted`: a memtable of 512 KB is still snapshotted as before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
