Caideyipi opened a new pull request, #19222:
URL: https://github.com/apache/iotdb/pull/19222

   ## Description
   
   Unsubscribe fails when metadata pushes encounter an unavailable registered 
DataNode. Allow unsubscribe execution and rollback to tolerate explicitly 
marked transport failures only when the DataNode is `Unknown` or `Stopped`. 
Keep metadata rejections, protocol/application errors, local dispatch errors, 
and failures from online nodes as failures. Other consumer-group operations 
retain their existing failure semantics.
   
   For example, with consumer `c` in group `g` subscribed to topic `t`, stop 
DN2 and wait until it is marked offline, then unsubscribe `c` from `t`. 
Previously, a connection failure while dropping the subscription Pipe or 
updating the consumer group caused unsubscribe to fail. With this change, 
unsubscribe can complete on the available nodes; DN2 receives the current 
metadata through the existing synchronization path after reconnecting. Failed 
consumer-group pushes are recorded by the ready tracker before transport 
failures are filtered.
   
   ## Validation
   
   - Pre-review local validation: an isolated clean-source build succeeded and 
24 targeted unit tests passed, including all newly added tests.
   - Independent workspace re-review completed with no confirmed actionable 
findings. The published source matches that reviewed snapshot.
   - Publication checks: clean candidate worktree, whitespace checks passed, 
and no merge conflicts with the refreshed `master`.
   - Real-cluster kill/rejoin integration testing has not been run.
   
   <hr>
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added unit tests or modified existing tests to cover new code paths.
   
   ##### Key changed/added classes
   
   `DataNodeTransportFailureUtils`, `PipePushMetaRPCHandler`, 
`ConsumerGroupPushMetaRPCHandler`, `ConfigNodeProcedureEnv`, 
`AlterConsumerGroupProcedure`, and `DropSubscriptionProcedure`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to