hongzhi-gao opened a new pull request, #19236:
URL: https://github.com/apache/iotdb/pull/19236

   ## Description
   
   Snapshot recovery without `snapshot.log` maintains a separate hard-link/copy 
branch. If the filesystem throws `UnsupportedOperationException`, recovery 
fails instead of copying the file. Its copy path also bypasses the force/error 
handling already used by logged snapshots.
   
   Use the existing `SnapshotFileUtils.createLinkOrCopy` for this path, keeping 
directory selection and file-target registration unchanged. Add a regression 
that rejects hard links, restores the bytes by copying, deletes the source, and 
verifies the restored contents and target mapping. Add the JDK 17 test JVM 
opens required by the existing PowerMock fault injection.
   
   Validation:
   - `mvn spotless:apply -o -pl iotdb-core/datanode -Ddevelocity.off=true`: 
passed.
   - `mvn test -o -pl iotdb-core/datanode -am 
'-Dtest=SnapshotFileUtilsTest,SnapshotLinkFallbackTest,IoTDBSnapshotTest' 
-Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false 
-Ddevelocity.off=true`: 15 passed, 1 pre-existing ignored test.
   - Cluster migration and crash-injection tests were not run.
   
   This PR has:
   - [x] been self-reviewed.
   - [x] added a regression test for the changed recovery path.
   
   Key changed classes: `SnapshotLoader`, `SnapshotLinkFallbackTest`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to