Caideyipi commented on PR #19241:
URL: https://github.com/apache/iotdb/pull/19241#issuecomment-6818402729

   ### Implemented-draft re-review
   
   Reviewed the complete PR diff and relevant context at 
`aa6b6acd01da446363f2e337c0163aaeeec0f4d6`, excluding the documented TODOs. 
This round found one actionable issue: when a legacy COMMIT/ABORT record was 
readable in staging but migration into `.finished` failed, 
`LoadTsFileManager.getTerminalOp()` propagated the migration `IOException`. 
Replicated retries for an already terminal task then returned permanent 
`LOAD_FILE_ERROR` instead of honoring the persisted decision.
   
   Fixed by returning the readable legacy terminal when publishing its migrated 
copy fails, while preserving the staging record so migration can be retried. 
Added `testReplicatedRetriesUseLegacyTerminalWhenMigrationFails`, covering 
remote PIECE, PREPARE, COMMIT, and ABORT against a legacy ABORT with an 
unavailable history directory.
   
   Validation: `mvn spotless:apply -P with-integration-tests` passed. The 
focused clean 28-module reactor command `mvn clean test -pl iotdb-core/datanode 
-am -P with-integration-tests -Dtest=LoadTsFileManagerTest 
-Dsurefire.failIfNoSpecifiedTests=false` passed with 40 tests, 0 failures, 0 
errors, and 0 skips. Datanode main and test sources were recompiled; 42 reactor 
goals were served from the Maven build cache. Checkstyle, Spotless, 
forbidden-API, and `git diff --check` passed. Restart ClusterIT, Chinese-locale 
build, process-kill recovery test, performance test, and full CI were not 
evaluated; no CI was awaited.
   
   Reviewed SHA: `aa6b6acd01da446363f2e337c0163aaeeec0f4d6`.
   Final local SHA: `a730680121d64c526ea2c41efc8961f9b6eced6b`.
   Confirmed source branch and PR HEAD: 
`a730680121d64c526ea2c41efc8961f9b6eced6b`.
   
   The PR remains draft because the documented TODOs are still incomplete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to