Caideyipi commented on PR #19243: URL: https://github.com/apache/iotdb/pull/19243#issuecomment-6818864411
Independent re-review: **one complete round, no actionable findings**. I reviewed the full current four-file diff against `apache/iotdb:master` at `d47472156d793fdaa13b8f87051f363222eddd50`, plus the related parser, processor, reference-count, queue cleanup, source ordering, and ordered-commit paths. No code changes, new commits, or push were needed. Areas checked: - [Original release and completion conditions](https://github.com/apache/iotdb/blob/4d311c88a4691425e4017a96877138c9365c3d23/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/PipeTsFileInsertionEvent.java#L595-L604), together with [generation and commit boundaries](https://github.com/apache/iotdb/blob/4d311c88a4691425e4017a96877138c9365c3d23/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tsfile/PipeTsFileInsertionEvent.java#L672-L734): the parsed/split paths wait for generation to finish and every registered output to commit or be discarded. A keyless original must finish releasing; an original assigned a committer key waits for its ordered commit. - [Processed Tablet ancestry and commit hooks](https://github.com/apache/iotdb/blob/4d311c88a4691425e4017a96877138c9365c3d23/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeRawTabletInsertionEvent.java#L119-L158), [discard hooks](https://github.com/apache/iotdb/blob/4d311c88a4691425e4017a96877138c9365c3d23/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/event/common/tablet/PipeRawTabletInsertionEvent.java#L365-L378), and [collector registration](https://github.com/apache/iotdb/blob/4d311c88a4691425e4017a96877138c9365c3d23/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/connection/PipeEventCollector.java#L288-L298): descendants retain the TsFile ancestor, are registered before queue publication, and share an exactly-once outcome guard between commit and discard. I found no additional missing, duplicate, or premature completion notification in the inspected paths. - [Regression tests](https://github.com/apache/iotdb/blob/4d311c88a4691425e4017a96877138c9365c3d23/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/pipe/source/PipeRealtimeExtractTest.java#L1495-L1786): the two table-file cases write and parse real TsFiles through the collector and cover both release/commit orders. The three processed-output cases use real tree TsFile parsing, `processRowByRow()`, and the collector; their assertions cover waiting for both outputs, repeated discard/cleanup, one completion notification, and an original commit blocked by an earlier commit ID. The modified generation-boundary case uses explicit lifecycle calls to cover an original released while generation is still open. Validation performed: static signature, call-site, lifecycle, and assertion inspection; `git diff --check` over the full PR diff; and scoped `mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode`. Spotless explicitly processed all four PR Java files: four already clean, zero changed. The initial formatter invocation stopped at Windows command-line quoting before Maven ran; the corrected invocation succeeded. **Compilation and tests were not run, as requested.** All five newly added PR tests remain unrun locally. Static inspection and formatting do not establish runtime correctness. CI was neither awaited nor polled, and no CI result is claimed. - Reviewed SHA: `4d311c88a4691425e4017a96877138c9365c3d23` - Final local SHA: `4d311c88a4691425e4017a96877138c9365c3d23` - Confirmed remote source-branch SHA: `4d311c88a4691425e4017a96877138c9365c3d23` - Confirmed PR head SHA: `4d311c88a4691425e4017a96877138c9365c3d23` The actual source branch and PR head were checked again at completion and still matched the reviewed commit. No update step remains incomplete. The PR remains **Draft**, as explicitly requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
