CritasWang commented on PR #19150: URL: https://github.com/apache/iotdb/pull/19150#issuecomment-6820344690
Pushed 49d840953a to address the three review comments: - Register the aligned import option and keep all measurement-indexed arguments paired, including aliases and metadata. - Reject non-string Tags/Attributes values before batching and record only the invalid rows in the failed file. - Handle an optional UTF-8 BOM and leading empty lines consistently during format detection and parsing, while retaining legacy CSV settings. Local validation on macOS with Microsoft OpenJDK 21: - `mvn -o clean test -pl iotdb-client/cli`: **108 tests, 0 failures/errors/skips**. - Full-reactor `mvn -o test-compile -DskipTests`, both with the default English locale and with `-P with-zh-locale`: **passed**. - `SchemaTagsRoundTripIT` through the real CLI scripts and server, using `SimpleIT` (1C1D) and `ClusterIT` (1C3D): **3 tests per profile, 0 failures/errors/skips**. This includes the existing export/import round trip and the new aligned-import and invalid-metadata cases. - Spotless, Checkstyle, integration-test selection, and English/Chinese message-key and placeholder parity checks passed. The integration runs used `-Drat.skip=true`: RAT was blocked by 263 pre-existing untracked local documentation files with unknown licenses. Those files were excluded from the commit, and all eight modified Java files retain their Apache license headers. Native Windows execution was not performed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
