Caideyipi commented on PR #19194:
URL: https://github.com/apache/iotdb/pull/19194#issuecomment-6842547396

   Review follow-up for `cabaa63fc95f7c0d897ffb938c0cb2374b00d479`:
   
   @jt2594838, addressed your [WALNode 
suggestion](https://github.com/apache/iotdb/pull/19194#pullrequestreview-5871041329).
 `WALNode.getReplicatedWalVersion()` now exposes a version published only after 
a batch containing replicated entries successfully flushes. Empty polls compare 
it with the version captured before the last prefetch round, so they do not 
repeatedly scan an unchanged WAL. Capturing the version before scanning also 
prevents replication arriving during the final scan from being lost when the 
worker becomes dormant. A counter provides this change signal without timestamp 
ordering or clock-resolution concerns.
   
   Regarding the [Codecov 
report](https://github.com/apache/iotdb/pull/19194#issuecomment-6739205011): 
the root Surefire configuration excludes `**/subscription/**` from default test 
runs. I explicitly exercised the subscription regressions and added normal 
WAL-buffer unit coverage for publication only after force, and for write/force 
failures. The new subscription tests use real WAL files and Mockito without 
PowerMock.
   
   Validation: clean compilation of the required IoTDB dependency closure in 
the 28-module reactor, Spotless, Checkstyle, and `git diff --check` passed. 
Surefire passed 11 WAL-buffer tests and 9 existing seek tests. The two new 
subscription tests passed in a focused JUnitCore rerun using the same reactor 
classes/JVM options and immutable TsFile dependency copies; their initial 
Surefire attempt encountered class-loading errors while the dependency JARs 
were replaced during the run. All five newly added tests have been run locally 
and passed. A temporary subscription-source enablement override was restored 
before committing. Full-suite and distributed integration testing were not run.
   
   Reviewed SHA: `3a343faaff65424068f357819ecfe97c8a41ca9d`. Final local and 
confirmed remote SHA: `cabaa63fc95f7c0d897ffb938c0cb2374b00d479`. The PR 
remains draft for a fresh independent re-review of this behavioral update. 
Discussions have been left unresolved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to