Caideyipi commented on PR #17871:
URL: https://github.com/apache/iotdb/pull/17871#issuecomment-6843549716

   Independent re-review completed for 
`063697ab5b89817786a987034b92d718f97e6d18` against baseline 
`cca1dbbde6d0dffa38495c92c92a48b2626d2f99`. I inspected the full 84-file diff 
and relevant implementation and test context.
   
   Found and fixed in `df4183ead2c54fa27c59420554da7e889f524ab6`:
   
   - **P2 — Triangle sampling lost INT64 precision for selected interior 
points.** When `2 < k < n`, selected values passed through `double`, which 
rounds integers above 2^53. The sampler now writes each selected point using 
its original typed value. The regression test covers interior selection and 
boundary cases. 
[UDTFSample.java:155](https://github.com/Caideyipi/iotdb/blob/df4183ead2c54fa27c59420554da7e889f524ab6/library-udf/src/main/java/org/apache/iotdb/library/dprofile/UDTFSample.java#L155)
   
   - **P2 — Spline timestamp arithmetic overflowed across the signed-long 
range.** Subtracting the origin timestamp and adding interpolated offsets in 
`long` could wrap. Coordinate differences and output timestamp interpolation 
now use `BigInteger`; a regression test covers timestamps from `Long.MIN_VALUE` 
through `Long.MAX_VALUE`. 
[UDTFSpline.java:88](https://github.com/Caideyipi/iotdb/blob/df4183ead2c54fa27c59420554da7e889f524ab6/library-udf/src/main/java/org/apache/iotdb/library/dprofile/UDTFSpline.java#L88)
   
   Validation:
   - Offline Spotless apply with `with-integration-tests`: passed.
   - Offline clean source reactor test with build cache disabled: **112 passed, 
0 failures, 0 errors, 0 skipped**. Checkstyle and Spotless checks passed in the 
reactor. All newly added tests were run locally.
   - `git diff --check`: passed.
   
   Final local commit, confirmed source branch head, and PR head are all 
`df4183ead2c54fa27c59420554da7e889f524ab6`. The PR remains **Draft** because 
this round found behavior issues; a fresh independent re-review is required. No 
CI was polled.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to