CRZbulabula commented on code in PR #19273: URL: https://github.com/apache/iotdb/pull/19273#discussion_r4573442635
########## iotdb-core/ainode/iotdb/ainode/core/model/tirex2/component/residual_block.py: ########## @@ -0,0 +1,64 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Copyright (c) NXAI GmbH. +# SPDX-License-Identifier: Apache-2.0 + +"""Residual MLP building blocks used across TiRex modules.""" + +import torch +from torch import nn + +from iotdb.ainode.core.model.tirex2.component.norm import RMSNorm + + [email protected] Review Comment: [P1] Make compilation optional for the packaged AINode runtime This unconditional `torch.compile` makes ordinary CPU inference fail in the shipped PyInstaller executable. In the [current AINode job](https://github.com/apache/iotdb/actions/runs/43508510960/job/132397535534), `forecastTableFunctionTest` fails with `CppCompileError: fatal error: Python.h: No such file or directory`: Inductor looks under the frozen executable's `_internal/include/python3.11`, which is not populated by the current packaging. The uploaded AINode log also shows the same error escaping `_requests_execute_loop` during the loaded-model test, killing the execution thread and leaving the query to time out. This is an actual runtime failure, beyond first-request compilation overhead. Please make compilation opt-in or provide a supported packaged compilation path with an eager fallback, and verify both direct and pooled forecasts using the built executable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
