luoluoyuyu opened a new pull request, #19291:
URL: https://github.com/apache/iotdb/pull/19291

   When a LOAD has to create the DataRegions of the TsFile it is loading, the 
Region allocator picks the replicas purely by the configured policy (GCR random 
weight, GREEDY free disk, PGP subgraph). Data that is partitioned by DataNode 
and loaded on the DataNode that produced it therefore usually ends up on 
another node, and every read of it has to cross the network.
   
   LOAD now accepts an opt-in attribute that pins the local DataNode as the 
first replica of each DataRegion created by that request:
   
     LOAD '/data/example.tsfile' WITH ('prefer-local-node'='true')
   
   The first replica is the DataNode that the write path routes the RegionGroup 
to, so the loaded data is also written locally. The remaining rf - 1 replicas 
are still chosen by the configured policy (GCR, GREEDY or PGP), which keeps all 
of its balancing keys in charge and only steers one slot.
   
   The preference is off by default and best-effort:
   
   - it only affects the DataRegions created by that request; existing Regions 
are never moved and SchemaRegions are never hinted;
   - it is honoured only while the local DataNode is Running and still a 
placement candidate, so it can neither place a replica on a DataNode that went 
down nor fail an otherwise servable request. A DataNode that fails while the 
RegionGroups are being created is repaired by the Region creation procedure 
with a regular replica re-allocation;
   - the replica order is re-sorted when a replica is added or removed later, 
so the locality is best-effort rather than sticky;
   - the attribute is carried through statement splitting, the tree-to-table 
conversion, the analysis-time tablet conversion, the fallback and rewrite 
conversions, the asynchronous load handoff and the active-load retry path. 
Pipe-generated loads never set it.
   
   The hint travels as TDataPartitionReq.preferredDataNodeId to the ConfigNode, 
where each allocator seeds the pinned replica and keeps its own policy for the 
rest of the replica set.
   
   
   <!--
   In each section, please describe design decisions made, including:
    - Choice of algorithms
    - Behavioral aspects. What configuration values are acceptable? How are 
corner cases and error 
       conditions handled, such as when there are insufficient resources?
    - Class organization and design (how the logic is split between classes, 
inheritance, composition, 
       design patterns)
    - Method organization and design (how the logic is split between methods, 
parameters and return types)
    - Naming (class, method, API, configuration, HTTP endpoint, names of 
emitted metrics)
   -->
   
   
   <!-- It's good to describe an alternative design (or mention an alternative 
name) for every design 
   (or naming) decision point and compare the alternatives with the designs 
that you've implemented 
   (or the names you've chosen) to highlight the advantages of the chosen 
designs and names. -->
   
   <!-- If there was a discussion of the design of the feature implemented in 
this PR elsewhere 
   (e. g. a "Proposal" issue, any other issue, or a thread in the development 
mailing list), 
   link to that discussion from this PR description and explain what have 
changed in your final design 
   compared to your original proposal or the consensus version in the end of 
the discussion. 
   If something hasn't changed since the original discussion, you can omit a 
detailed discussion of 
   those aspects of the design here, perhaps apart from brief mentioning for 
the sake of readability 
   of this PR description. -->
   
   <!-- Some of the aspects mentioned above may be omitted for simple and small 
changes. -->
   
   <hr>
   
   This PR has:
   - [ ] been self-reviewed.
       - [ ] concurrent read
       - [ ] concurrent write
       - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code 
wherever would not be obvious 
     for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, 
ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not 
all of these items 
   apply to every PR. Remove the items which are not done or not relevant to 
the PR. None of the items 
   from the checklist above are strictly necessary, but it would be very 
helpful if you at least 
   self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) 
in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to