Caideyipi commented on code in PR #19308:
URL: https://github.com/apache/iotdb/pull/19308#discussion_r4610028299
##########
iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java:
##########
@@ -2899,6 +2901,20 @@ private void insertTabletInternal(Tablet tablet,
TSInsertTabletReq request)
}
}
+ /**
+ * Tests a table-model tablet without writing data or changing metadata.
Analysis and later stages
+ * require existing schema, devices and partitions, and must not require
attribute updates.
+ */
+ public void testInsertRelationalTablet(Tablet tablet, TestInsertStage stage)
+ throws IoTDBConnectionException, StatementExecutionException {
+ Objects.requireNonNull(stage, SessionMessages.EXCEPTION_STAGE_9A8C2B9D);
+ TSInsertTabletReq request = genTSInsertTabletReq(tablet, false, false);
+ request.setWriteToTable(true);
Review Comment:
`genTSInsertTabletReq` returns `null` when `SessionUtils.filterNullColumns`
removes every FIELD column. This path dereferences that null request, so a
staged table-model tablet containing only all-null FIELD columns throws a
client-side `NullPointerException` before the RPC. Please handle the
filtered-empty case explicitly and cover it in a test; the tree staged tablet
overloads also lack explicit handling for a filtered-empty request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]