Caideyipi commented on PR #19282:
URL: https://github.com/apache/iotdb/pull/19282#issuecomment-6971810724

   ### Self-review summary (re-review)
   
   - Reviewed SHA: `6788ae035ba0d6e1902ad72866c6a346f0d53954`. Found one 
architecture violation: `PipeTabletUtils.putFieldValue` switched on 
`TSDataType` outside `TypeService`.
   - Fixed by routing type-specific field writing through 
`TypeServices.Pipe.PIPE_FIELD_TABLET_VALUE_WRITER_SERVICE`, preserving the 
existing null-field, DATE, and binary behavior.
   - Verification: Spotless passed. Focused DataNode tests passed: 5 tests, 0 
failures, 0 errors, 0 skipped. Tests used TsFile artifacts built from source 
commit `a1d3547f525c9a58f4c59eebb1757930672401dd` with `2.5.1-SNAPSHOT` as the 
local override because `2.5.1-261118-SNAPSHOT` was not installed locally; the 
PR retains the requested dependency version.
   - Final local SHA: `685d6fe012f97c731cebcd4958664f8704964101`. Confirmed 
remote branch and PR head: the same SHA. PR remains open and non-draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to