farisbasha opened a new pull request, #19320: URL: https://github.com/apache/iotdb/pull/19320
## Description Two comments in `iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template` contradict the code and the value written right below them. ### `enable_auto_leader_balance_for_ratis_consensus` The comment says `Notice: Default is false because the Ratis is unstable for this function.`, but the template sets `enable_auto_leader_balance_for_ratis_consensus=true`, and the code default is also `true`: - `ConfigNodeConfig.java`: `private boolean enableAutoLeaderBalanceForRatisConsensus = true;` - `ConfigNodeDescriptor.java` reads the key with `String.valueOf(conf.isEnableAutoLeaderBalanceForRatisConsensus())` as the fallback. A user reading the template is told the feature is off by default when it is on. The stale notice line is removed; the rest of the comment is unchanged. ### `max_expired_time` The comment says `Datatype: int`, but the value is `2592000000` (30 days in ms), which is larger than `Integer.MAX_VALUE` (2147483647). The code stores it as `long maxExpiredTime = 2_592_000_000L` (`IoTDBConfig.java`) and parses it with `Long.parseLong` (`IoTDBDescriptor.java`). The datatype is changed to `long`. Comment-only change in the configuration template; no code or default value changes. <hr> ##### Key changed/added classes (or packages if there are too many classes) in this PR - `iotdb-system.properties.template` (comments only) This was found with the help of an AI assistant. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
