Caideyipi commented on PR #19318:
URL: https://github.com/apache/iotdb/pull/19318#issuecomment-7001608725

   Independent review found premature readiness: the startup callback marked 
leader services ready before Procedure workers started, allowing external 
requests to enter while startup was incomplete. Removing that early mark 
exposed a second dependency: recovered Procedures need internal metadata writes 
between the Pipe callback and worker startup; treating all requests as not 
ready blocked those writes and timed out both recovery cases.
   
   The final fix runs the Pipe leader-change callback after procedure recovery 
but before workers start, permits internal Procedure requests after that 
callback, and keeps external requests gated until startExecutor() returns. 
Existing-executor handling and epoch checks remain intact.
   
   Verification on bc0630b0f5fd45031067076a5f219de621f70d7d: Spotless passed. 
IoTDBProcedureIT passed under the default and ClusterIT profiles (3 tests each; 
zero failures, errors, or skips), covering same-node and cross-ConfigNode 
recovery. RAT remains unverified; the task record notes five generated 
client-go files with license-header issues, so these targeted test runs used 
-Drat.skip=true.
   
   The pull request remains a draft pending fresh independent re-review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to