Caideyipi commented on PR #19327:
URL: https://github.com/apache/iotdb/pull/19327#issuecomment-7028087478

   Follow-up review of the DataNode CI failure at 
`9130bcd16d1a4dd6b7e8f16e7a70ee82748b1691` found that both metric sets used 
pipe deregistration from `unbindFrom`. `MetricService.restartService()` unbinds 
and then rebinds each set, so this discarded still-live pipe/operator state 
before metrics could be recreated. The fix removes registered metric instances 
during unbind while preserving active pipe/operator state for the bind phase.
   
   Validation: Spotless and `git diff --check` passed. The clean targeted Maven 
run passed `PipeMetricsLifecycleTest` and 
`PipeDataNodeSinglePipeMetricsLifecycleTest` (4 tests, 0 failures/errors).
   
   Reviewed SHA: `9130bcd16d1a4dd6b7e8f16e7a70ee82748b1691`.
   Final local and confirmed remote PR head: 
`298cc7b8f58525239d4a619e8f549f79b61ec92c`.
   Remote CI for the updated head is in progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to