Adar Dembo has posted comments on this change.

Change subject: KUDU-1311 [master] support adding and dropping range partitions
......................................................................


Patch Set 13:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3648/12/src/kudu/integration-tests/alter_table-test.cc
File src/kudu/integration-tests/alter_table-test.cc:

Line 1152:   ASSERT_OK(table_alterer->Alter());
Not sure why this was commented out, but this block no longer does what the 
comment says it does (drop some partitions AND alter the schema).


http://gerrit.cloudera.org:8080/#/c/3648/13/src/kudu/tools/ksck.cc
File src/kudu/tools/ksck.cc:

Line 305:   if (num_tablets > 0 && num_tablet_replicas == 0) {
Could you explain the significance of the change here? It's not obvious to me.


-- 
To view, visit http://gerrit.cloudera.org:8080/3648
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42437f365397baf9d4b39b5b17a1587fae70c4be
Gerrit-PatchSet: 13
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to