Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ksck: fix a crash in checksum mode on tables with many tablets ......................................................................
ksck: fix a crash in checksum mode on tables with many tablets In the case that the list of tablets had to be fetched in multiple batches, we would improperly re-fetch the last tablet of the previous batch as the first tablet of the next batch. This would then cause a tablet to be inserted twice into the list, which would later cause a CHECK failure when we tried to InsertOrDie() this tablet ID into a map. This fixes the issue by making sure that we look for more tablets starting with the *successor* partition key compared to the previous tablet we fetched. I also updated the integration test to use a table with more tablets so that the batching code was exercised. Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355 Reviewed-on: http://gerrit.cloudera.org:8080/3714 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans <[email protected]> --- M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc 2 files changed, 17 insertions(+), 10 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3714 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ca7ef75bd22ce27885e31ab20cf0e8e0ee2d355 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]>
