Jean-Daniel Cryans has submitted this change and it was merged. Change subject: ksck: improve output for long-running ksck checksums ......................................................................
ksck: improve output for long-running ksck checksums Checksumming a large (multi-TB) table can take many minutes. Previously, the ksck output would be very quiet during that time, giving no indication as to whether it was making progress or how much work might be remaining. This addresses that by: - passing back how many bytes and number of rows have been summed so far on a regular basis - reporting progress every 5 seconds, including the above numbers Along the way, I decided that our default timeout of 5 minutes was way too low for typical table sizes, so bumped it to an hour. I also added more mock-based test coverage of the checksum-scan code path. Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825 Reviewed-on: http://gerrit.cloudera.org:8080/3715 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans <jdcry...@apache.org> --- M src/kudu/tools/ksck-test.cc M src/kudu/tools/ksck.cc M src/kudu/tools/ksck.h M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/ksck_remote.cc M src/kudu/tools/ksck_remote.h M src/kudu/tserver/tablet_server-test.cc M src/kudu/tserver/tablet_service.cc M src/kudu/tserver/tserver_service.proto 9 files changed, 179 insertions(+), 61 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
