Dan Burkert has posted comments on this change.

Change subject: WIP [java client] Support add/remove partition
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3731/1/java/kudu-client/src/main/java/org/kududb/client/AlterTableOptions.java
File java/kudu-client/src/main/java/org/kududb/client/AlterTableOptions.java:

Line 34:   private boolean addsRangePartitions = false;
In the latest version of the c++ patch this has been simplified to a single 
flag that's set if either add or drop is happening.  The caches get cleared in 
either case.


http://gerrit.cloudera.org:8080/#/c/3731/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java:

Line 367:     // TODO something about feature flags.
if either add/or drop is happening then we need to make sure the RPC sets the 
ADD_DROP_RANGE_PARTITIONS flag.


-- 
To view, visit http://gerrit.cloudera.org:8080/3731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba18cbaf87bb738af7f108311ecc5738129ae092
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to