Mike Percy has posted comments on this change.

Change subject: KUDU-526: use on-disk cmeta when loading existing master state
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

This patch looks fine to me. It obviously converts the gflags from a command to 
a suggestion on startup, but we already knew that was coming. Needs docs, but 
it's reasonable to defer than until we're done changing stuff to do.

http://gerrit.cloudera.org:8080/#/c/3786/1/src/kudu/integration-tests/master_failover-itest.cc
File src/kudu/integration-tests/master_failover-itest.cc:

Line 330: TEST_F(MasterFailoverTest, TestKUDU526) {
nit: how about TestMasterUUIDResolution or something (you can add a comment 
about KUDU-526 if you want but I'm not sure it adds any incremental clarity)


-- 
To view, visit http://gerrit.cloudera.org:8080/3786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b4c6d8b6adf696973445a6f9d1314ba9de27e70
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-HasComments: Yes

Reply via email to