song bruce zhang has posted comments on this change.

Change subject: KUDU-1542: in some cases apply will hang.
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3787/2/java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java
File java/kudu-client/src/main/java/org/apache/kudu/client/KuduSession.java:

Line 88:         } catch (com.stumbleupon.async.TimeoutException e) {
> Wouldn't it be better to just check if the RPC has timed out?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3787
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iacd33cdc5316e294e613d1b2273ef12e6b1cf687
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: song bruce zhang <zsyuyizh...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to