Hello Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3809
to look at the new patch set (#3).
Change subject: c++ client: remove unnecessary code
......................................................................
c++ client: remove unnecessary code
1. GetTableSchema() was implemented using its own RPC instead of a much
simpler call to SyncLeaderMasterRpc(). An RPC is attractive for
asynchronous use, but since it's never used that way, let's just switch
over to SyncLeaderMasterRpc().
2. KuduTable::Open() was issuing both GetTableSchema() and
GetTableLocations() RPCs. It's not clear why we're doing the latter; the
response is completely ignored. So let's stop doing that.
My main motivation is to remove fragile error-handling and retry logic which
has been duplicated all over the client.
Change-Id: Idda2cc15bc6224df992bfe2eec287c0222adced0
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client.cc
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
4 files changed, 34 insertions(+), 304 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/3809/3
--
To view, visit http://gerrit.cloudera.org:8080/3809
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idda2cc15bc6224df992bfe2eec287c0222adced0
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
