Adar Dembo has posted comments on this change. Change subject: [util] fixed build on MacOS X ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3836/1/src/kudu/util/CMakeLists.txt File src/kudu/util/CMakeLists.txt: Line 209: dl > At my laptop the error looks like It probably means -ldl can resolve to something on macOS, so kudu_test_main can link properly. However, Kudu's main CMakeLists.txt file does NOT create dl and dl_exported targets on macOS, so when the dl dependency sneaks into ADD_EXPORTABLY_LIBRARY(), -ldl_exported cannot resolve. -- To view, visit http://gerrit.cloudera.org:8080/3836 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894adf2d5f961eea567a32c6bb85af8998ce4adb Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
