Todd Lipcon has posted comments on this change.

Change subject: KUDU-526: use on-disk cmeta when loading existing master state
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3786/3/src/kudu/master/sys_catalog.cc
File src/kudu/master/sys_catalog.cc:

Line 110:   if (master_->opts().IsDistributed()) {
should we be verifying that, if the user passed any configuration on the 
command line, that it matches the configuration in the cmeta? otherwise seems 
like a user can get into a very hard-to-understand state if they do something 
like accidentally start the master with a typo in the host and then try to 
restart and correct it, no?


-- 
To view, visit http://gerrit.cloudera.org:8080/3786
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5b4c6d8b6adf696973445a6f9d1314ba9de27e70
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to