Todd Lipcon has posted comments on this change.

Change subject: Predicate evaluation pushdown
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3841/1/src/kudu/cfile/binary_dict_block.cc
File src/kudu/cfile/binary_dict_block.cc:

Line 390:     SeekAtOrAfterDictValue(ctx->pred().raw_lower(), &lower_exact, 
lower_codeword);
could you change the API so that this only happens once when you construct the 
decoder, rather than once per row batch? That way you amortize all this "setup" 
cost across the entire cfile, instead of once per 1000 records, and should see 
a much bigger speedup


-- 
To view, visit http://gerrit.cloudera.org:8080/3841
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6298defd710bc7badcc8f390d933b5b8613974e0
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to