Adar Dembo has posted comments on this change.

Change subject: master: additional leader lock assertions in catalog manager
......................................................................


Patch Set 5:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3684/5/src/kudu/master/catalog_manager.h
File src/kudu/master/catalog_manager.h:

Line 470:   // Return true if the table with the specified ID exists,
> doesn't return bool
Done


Line 473:   Status GetTableInfo(const std::string& table_id, 
scoped_refptr<TableInfo> *table);
> should update docs to explain bad status results
Done


Line 477:   Status GetAllTables(std::vector<scoped_refptr<TableInfo>>* tables);
> same here
Done


Line 479:   // Return true if the specified table name exists
> same
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5bb2f5067cdbdd93900a80255def65a26216f6ea
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to