Adar Dembo has submitted this change and it was merged. Change subject: remote_bootstrap_client: mild API changes ......................................................................
remote_bootstrap_client: mild API changes 1. I removed the uuid argument from the constructor; it's always the uuid of the FsManager. 2. I made the TabletStatusListener argument to FetchAll() optional. I think that was the original intent (because the TabletMetadata OUT parameter in Start() is optional), but a CHECK_NOTNULL() got added at some point. 3. I removed the peer uuid argument from Start(). It was only used for logging, so I added an equivalent field to the response protocol. Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1 Reviewed-on: http://gerrit.cloudera.org:8080/3811 Tested-by: Kudu Jenkins Reviewed-by: Todd Lipcon <[email protected]> --- M src/kudu/integration-tests/remote_bootstrap-itest.cc M src/kudu/tserver/remote_bootstrap.proto M src/kudu/tserver/remote_bootstrap_client-test.cc M src/kudu/tserver/remote_bootstrap_client.cc M src/kudu/tserver/remote_bootstrap_client.h M src/kudu/tserver/remote_bootstrap_service.cc M src/kudu/tserver/ts_tablet_manager.cc 7 files changed, 49 insertions(+), 52 deletions(-) Approvals: Todd Lipcon: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3811 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id7f482d1193a5a46fa51488eab4712c0c4bfceb1 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]>
