Adar Dembo has posted comments on this change.

Change subject: [C++ client] doxygenized all C++ client API
......................................................................


Patch Set 4:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/client/callbacks.h
File src/kudu/client/callbacks.h:

Line 60:   /// @param [in] line_number
> Done
You missed the change from "is" to "was".


http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/client/callbacks.h
File src/kudu/client/callbacks.h:

Line 46:   KuduLoggingCallback() {
Why do we need this?


http://gerrit.cloudera.org:8080/#/c/3840/4/src/kudu/util/slice.h
File src/kudu/util/slice.h:

Line 137:   /// @note The data isn't actually modified, just the base/bounds of 
the slice.
Nit: restyled a bit: "Only the base and bounds of the slice are changed; the 
data is not modified." Below too.


http://gerrit.cloudera.org:8080/#/c/3840/2/src/kudu/util/status.h
File src/kudu/util/status.h:

Line 30: #define KUDU_RETURN_NOT_OK(s) do { \
> These macros are user-facing; should we doxygenate their comments too?
I think you missed this comment.


-- 
To view, visit http://gerrit.cloudera.org:8080/3840
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id0f82a6c8a500a892bc1daff8444e91191dab3af
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to