Dan Burkert has posted comments on this change. Change subject: Add table id to AlterTableResponsePB ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3859/2/java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java File java/kudu-client/src/main/java/org/apache/kudu/client/AlterTableResponse.java: Line 26: String tableId; > private? Done Line 37: * @return the ID of the altered table, or null if the master version is too old (< 0.10) > I think we should avoid embedding version numbers directly in the code like Done http://gerrit.cloudera.org:8080/#/c/3859/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 361: // version to return the table ID (>= 0.10), we can selectively clear > Nit: version string here too. Done Line 365: if (resp instanceof AlterTableResponse) { > The type erasure here is annoying. The only way to avoid it would be to dup Done -- To view, visit http://gerrit.cloudera.org:8080/3859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63402581fbdaef2abdf37910c1dfaedbdcba76e2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
