Dan Burkert has posted comments on this change.

Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert
......................................................................


Patch Set 2:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/3871/2//COMMIT_MSG
Commit Message:

Line 19: The change is backwards-incompatible. Syntax like
> Maybe a silly question: should I add it as part of this patch or get it add
That one's been committed, so you won't need to worry about a merge conflict.  
You can follow the lead set out by Todd in formatting, though.


http://gerrit.cloudera.org:8080/#/c/3871/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala
File 
java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala:

PS2, Line 172: insert
> I agree people will want upsert by default, but it makes me a little nervou
I think that's what we want (A sparksql INSERT INTO defaulting to a Kudu 
upsert), but maybe we should bring it up on the mailing list, or at least pull 
in some of the other known kudu-spark users into this discussion.  I'll ping 
some people on slack, but if you want to start a discuss thread on the mailing 
list that would probably be good too.  Wish we had more time before 0.10 :)


http://gerrit.cloudera.org:8080/#/c/3871/2/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala
File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/package.scala:

Line 35
> It's tied to CreatableRelationProvider. I crossed my fingers and tried it w
So I'm not quite following, it sounds like using this will cause a runtime 
exception?  Why add it back in that case?


http://gerrit.cloudera.org:8080/#/c/3871/2/java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala
File 
java/kudu-spark/src/test/scala/org/apache/kudu/spark/kudu/DefaultSourceTest.scala:

Line 75:     val tableName = "testcreatetable"
> np. Actually, I'd also like to do a follow up patch just to clean up the co
That would be greatly appreciated.


-- 
To view, visit http://gerrit.cloudera.org:8080/3871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e0d50fb74dc2ce5e757e8a56fc1e863f699822
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Chris George <chris.geo...@rms.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to