Chris George has posted comments on this change.

Change subject: KUDU-1533 Spark Kudu Rdd/Dataframe upsert
......................................................................


Patch Set 3: Code-Review-1

I would prefer that we not drop CreatableRelationProvider. I'm using cassandra 
spark connector as a precedent for this. They error out when attempting to 
append to a non existent table. I think there is a valid case for not allowing 
overwrite for the reasons stated previously about not having enough 
information. However it would be possible to add this if we put additional 
options, but I'm ok with not allowing this support unless we supported backend 
truncates. I think implementing CreateableRelation allows newer spark users to 
have less of a learning curve when adopting the new datasource. However I think 
the documentation should be updated to use the prefered approach. I think 
append should default to upsert and then we should throw an error back for 
overwrite. Also a -1 because the documentation needs to be updated with example 
usages.

-- 
To view, visit http://gerrit.cloudera.org:8080/3871
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8e0d50fb74dc2ce5e757e8a56fc1e863f699822
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Chris George <chris.geo...@rms.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <ram.me...@rms.com>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
Gerrit-HasComments: No

Reply via email to