Mike Percy has posted comments on this change. Change subject: KUDU-564 (part 1): log a 'diff' when tablet config changes ......................................................................
Patch Set 1: Code-Review+2 (1 comment) Nice. Looks good except for one thing I was wondering about http://gerrit.cloudera.org:8080/#/c/3939/1/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: Line 255: peer_infos[old_state.leader_uuid()].first.last_known_addr().host(), not guaranteed to have a leader so i am not sure what happens when last_known_addr is empty. Is it friendly and we just end up with an empty string from host()? Maybe we want a somewhat nicer message in that case. -- To view, visit http://gerrit.cloudera.org:8080/3939 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb785093176eea067de039b14f6600084998861a Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
