Todd Lipcon has posted comments on this change. Change subject: monotime: remove granularity argument ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3966/1//COMMIT_MSG Commit Message: Line 13: Let's remove it for now so that the API is a little simpler. If we ever > Having this clean-up is great! Yea, I considered just making it a default parameter, but it's "discouraged" in the guidelines (though we use them sometimes). I couldn't really find any good reasons for COARSE to exist, though -- it seems like the only time we care about performance of MonoTime::Now() is when we're timing a very fast-running function and don't want the time-collection overhead to drown out the actual function runtime. But, in that case, we also need high precision for the time to be correct, so COARSE isnt that useful anyway. -- To view, visit http://gerrit.cloudera.org:8080/3966 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1d375d54e8598105f3ec833c37d96a382c1a8f7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
