Dan Burkert has posted comments on this change.

Change subject: KUDU-1474: single to multi-master deployment migration
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3880/4/src/kudu/integration-tests/master_migration-itest.cc
File src/kudu/integration-tests/master_migration-itest.cc:

Line 44: using kudu::master::SysCatalogTable;
> Doesn't work; I'm already using client::sp::shared_ptr, and I need to use t
ah, I misunderstood, I thought it was just missing.


http://gerrit.cloudera.org:8080/#/c/3880/4/src/kudu/master/sys_catalog.h
File src/kudu/master/sys_catalog.h:

PS4, Line 67: static const char* const kSy
> Doesn't actually work; cpplint complains about using std::string for global
Ah ok, I didn't know about the potential for a shutdown race condition.


http://gerrit.cloudera.org:8080/#/c/3880/6/src/kudu/tools/tool_action.h
File src/kudu/tools/tool_action.h:

Line 98: Status CheckNoMoreArgs(const std::vector<Action>& chain, CONTAINER 
args) {
I think this can take the CONTAINER by const ref.


-- 
To view, visit http://gerrit.cloudera.org:8080/3880
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89c741381ced3731736228cd07fe85106ae72541
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to