Todd Lipcon has posted comments on this change.

Change subject: Add time/watermark based garbage collection to ResultTracker
......................................................................


Patch Set 15:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3628/15/src/kudu/rpc/service_if.cc
File src/kudu/rpc/service_if.cc:

Line 104:   RpcContext* ctx = new RpcContext(call,
> ah, good catch... I wonder why leak sanitizer builds are not catching this.
oh.. it's some slightly weird design going on here -- ResultTracker itself will 
have responded to the RPC in these cases, and thus deleted the context itself. 
I added a comment to that effect since it does _look_ like a leak.


-- 
To view, visit http://gerrit.cloudera.org:8080/3628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c8e7b7191ca14842a31b64813ed498bdf626fa8
Gerrit-PatchSet: 15
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to