Adar Dembo has posted comments on this change.

Change subject: fs: allow format with user-specified uuid
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3968/2/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

Line 326:     metadata->set_uuid(uuid.get());
> As we discussed on Slack, I'm -1 on this if it breaks the UUID invariant on
You get a validation and you get a validation! Everyone gets a validation!


-- 
To view, visit http://gerrit.cloudera.org:8080/3968
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4189d6150a263b7dde304dd19a449d3c0ab6c8c
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <d...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to