Todd Lipcon has posted comments on this change.

Change subject: tool: rewrite parser logic
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3996/1/src/kudu/tools/tool_action.h
File src/kudu/tools/tool_action.h:

PS1, Line 66: // Invokes an action, passing in the complete action chain and 
all remaining
            : // command line arguments. The arguments are passed by value so 
that the
            : // function can modify them if need be.
what's this comment attached to?


PS1, Line 94:  // After Build() is called, submodes_ and actions_ are empty.
hrm, isn't it better to just say 'May be only called once'?


-- 
To view, visit http://gerrit.cloudera.org:8080/3996
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I794fc527525a57283f0165e262283adf14160def
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to