Dinesh Bhat has posted comments on this change. Change subject: catalog_manager: avoid more races between Init() and GetTabletPeer() ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3997/1//COMMIT_MSG Commit Message: Line 15: master_replication-itest: /home/jenkins-slave/workspace/kudu-3/src/kudu/gutil/ref_counted.h:273: T *scoped_refptr<kudu::tablet::TabletPeer>::operator->() const [T = kudu::tablet::TabletPeer]: Assertion `ptr_ != __null' failed. That's a first time I am seeing a stacktrace in a commit message, well as they say there is a first time for everything :) http://gerrit.cloudera.org:8080/#/c/3997/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: Line 706: sys_catalog_.reset(new_catalog.release()); Purely looking from this context alone, would this race be seen if we were to make sys_catalog_ a shared_ptr instead of gscope_ptr ? -- To view, visit http://gerrit.cloudera.org:8080/3997 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43fdc6499cb84d2053bed08b689fe5a08a6761d6 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
